Skip to content

Conversation

milanov
Copy link
Contributor

@milanov milanov commented Feb 2, 2020

No description provided.

@milanov
Copy link
Contributor Author

milanov commented Feb 2, 2020

That test fails for me locally as well, but to be honest i have not much clue as to how to fix it, and i can't trace it back to my changes:

[ERROR] Failures: 
5489[ERROR]   JdbcRepositoryIntegrationTests.executeQueryWithParameterRequiringConversion:281 
5490Expecting:
5491  <[JdbcRepositoryIntegrationTests.DummyEntity(name=second, idProp=3, pointInTime=2020-02-02T10:51:02.030Z)]>
5492to contain exactly (and in same order):
5493  <[JdbcRepositoryIntegrationTests.DummyEntity(name=second, idProp=3, pointInTime=2020-02-02T10:51:02.030009Z)]>
5494but some elements were not found:
5495  <[JdbcRepositoryIntegrationTests.DummyEntity(name=second, idProp=3, pointInTime=2020-02-02T10:51:02.030009Z)]>
5496and others were not expected:
5497  <[JdbcRepositoryIntegrationTests.DummyEntity(name=second, idProp=3, pointInTime=2020-02-02T10:51:02.030Z)]>

@schauder
Copy link
Contributor

schauder commented Feb 3, 2020

That test works for me. Looks like fun with milli/nanoseconds once more. What operating system and JDK are you using?

@milanov
Copy link
Contributor Author

milanov commented Feb 6, 2020

Actually the log is from the travis CI (https://travis-ci.org/spring-projects/spring-data-jdbc/builds/645027523) build. Locally it fails on MacOS/Java "11.0.3" 2019-04-16 LTS.

@schauder
Copy link
Contributor

schauder commented Feb 6, 2020

Thanks, I created a separate issue for that: https://jira.spring.io/browse/DATAJDBC-484

schauder pushed a commit that referenced this pull request Feb 7, 2020
schauder added a commit that referenced this pull request Feb 7, 2020
Refactored SQL generation.
Adapted some assertions to the "Spring Data JDBC style".
Minor formatting.

Original pull request: #188.
@schauder
Copy link
Contributor

schauder commented Feb 7, 2020

That is polished and merged. Thanks a lot for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants