DATAJDBC-490 - Support condition nesting #193
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schauder
requested changes
Feb 21, 2020
There was a problem hiding this comment.
I'm not to fond of the group approach. asGroup would be slightly better.
But the real beef I have is that it reads like a mixture of normal and reverse Polish notation.
I'd rather have constructors or static method, so one may write
or(
left.greaterThan(right).and(<....>),
<some other expression>
)and the same for AND.
I also added a commit adding a test that I think should succeed but doesn't.
|
Thanks for having a look. I also felt that |
mp911de
changed the title
We now support condition groups (WHERE (a = b OR b = c) AND (e = f)) with the SQL AST via Condition.group().
Rename ConditionGroup to GroupedCondition. Introduce Conditions.group(…) factory method instead of applying grouping via `condition.group()`. Introduce getter to introspect conditions.
mp911de
force-pushed
the
issue/DATAJDBC-490
branch
from
905245e to
321699e
Compare
schauder
pushed a commit
that referenced
this pull request
Mar 10, 2020
We now support condition groups (WHERE (a = b OR b = c) AND (e = f)) with the SQL AST via Condition.group(). Original pull request: #193.
schauder
pushed a commit
that referenced
this pull request
Mar 10, 2020
Rename ConditionGroup to GroupedCondition. Introduce Conditions.group(…) factory method instead of applying grouping via `condition.group()`. Introduce getter to introspect conditions. Original pull request: #193.
schauder
pushed a commit
that referenced
this pull request
Mar 10, 2020
…UP BY. Original pull request: #193.
schauder
added a commit
that referenced
this pull request
Mar 10, 2020
Renamed GroupedConditionVisitor to NestedConditionVisitor to match the renamed NestedCondition. Original pull request: #193.
|
That's on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now support condition groups
(WHERE (a = b OR b = c) AND (e = f))with the SQL AST viaCondition.group().We should make sure that
Condition.group()is a sufficiently expressive method name. MaybeasGroup()or any other variant is more appropriate?Related ticket: DATAJDBC-490.