DATAJDBC-145 - Back-reference in insert now honours NamingStrategy. #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a property path to DbActions in order to make them aware of the property it is related to. Then used the JdbcPersistentProperty based on that get the name of the back-reference name of that property back to the root entity of that property. This gets the NamingStrategy properly involved, as it should. Instead of using the vanilla PropertyPath a new JdbcPropertyPath is introduced. It allows for an empty path avoiding various null-checks. Upgraded SD-Commons dependency to 2.1.x in order to utilise DATACMNS-1199. Related issues: DATACMNS-1204 DATACMSN-1199
Added a property path to DbActions in order to make them aware of the property it is related to. Then used the JdbcPersistentProperty based on that get the name of the back-reference name of that property back to the root entity of that property. This gets the NamingStrategy properly involved, as it should. Instead of using the vanilla PropertyPath a new JdbcPropertyPath is introduced. It allows for an empty path avoiding various null-checks. Upgraded SD-Commons dependency to 2.1.x in order to utilise DATACMNS-1199. Removed the now superfluous PropertyPaths and used PropertyPath methods instead. Related issues: DATACMNS-1204 DATACMSN-1199
mp911de
added a commit
that referenced
this pull request
Feb 21, 2022
…QL Server. We now provide dialect support for H2, PostgreSQL, and Microsoft SQL Server databases, configurable through AbstractR2dbcConfiguration. By default, we obtain the Dialect by inspecting ConnectionFactoryMetadata to identify the database and the most likely dialect to use. BindableOperation encapsulates statements/queries that can accept parameters. Use BindableOperation for statements through DatabaseClient. Extract SQL creation. Split integration test into abstract base class that can be implemented with a database-specific test class. Original pull request: #24.
mp911de
pushed a commit
that referenced
this pull request
Feb 21, 2022
Rename Database.latestDialect() to defaultDialect(). Rename Dialect.returnGeneratedKeys() to Dialect.generatedKeysClause(). Simplify IndexBindMarkers. Create BindableOperation.bind(Statement, SettableValue) to reduce code duplicates. Rename BindSpecWrapper to BindSpecAdapter. Original pull request: #24.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DATAJDBC-145 - Back-reference in insert now honours NamingStrategy.
Added a property path to DbActions in order to make them aware of the property it is related to.
Then used the JdbcPersistentProperty based on that get the name of the back-reference name of that property back to the root entity of that property.
This gets the NamingStrategy properly involved, as it should.
Instead of using the vanilla PropertyPath a new JdbcPropertyPath is introduced.
It allows for an empty path avoiding various null-checks.
Upgraded SD-Commons dependency to 2.1.x in order to utilise DATACMNS-1199.
Removed the now superfluous PropertyPaths and used PropertyPath methods instead.
Related issues:
DATACMNS-1204
DATACMSN-1199