Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify domain object dependency injection through use of generics [SPR-5920] #10589

Closed
spring-projects-issues opened this issue Jul 11, 2009 · 0 comments
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

Ramnivas Laddad opened SPR-5920 and commented

Currently, users who extend AbstractInterfaceDrivenDependencyInjectionAspect need to have some knowledge of AspectJ constructs. Specifically, they need to know about the 'declare parents' construct and the pointcut syntax. With the help of generics, we should be able to remove both these issues paving the way for type-safe aspect that requires no/little knowledge of AspectJ.

So instead of:
aspect PricingStrategyDependencyInjectionAspect extends AbstractInterfaceDrivenDependencyInjectionAspect {
private PricingStrategy pricingStrategy;

	public pointcut inConfigurableBean() : within(PricingStrategyClient+);
	
	public void configureBean(Object bean) {
		((PricingStrategyClient)bean).setPricingStrategy(this.pricingStrategy);
	}
	
	declare parents: PricingStrategyClient implements ConfigurableObject;
	
	public void setPricingStrategy(PricingStrategy pricingStrategy) {
		this.pricingStrategy = pricingStrategy;
	}
}

they can write:

aspect PricingStrategyDependencyInjectionAspect extends GenericInterfaceDrivenDependencyInjectionAspect<PricingStrategyClient> {
	private PricingStrategy pricingStrategy;
	
	public void configure(PricingStrategyClient bean) {
		bean.setPricingStrategy(pricingStrategy);
	}
	
	public void setPricingStrategy(PricingStrategy pricingStrategy) {
		this.pricingStrategy = pricingStrategy;
	}
}

Affects: 3.0 M3

Referenced from: commits 29139df

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: core Issues in core modules (aop, beans, core, context, expression) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 3.0 M4 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant