Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make spring-aop required for spring-context (in spring-context POM) [SPR-6578] #11244

Closed
spring-projects-issues opened this issue Dec 17, 2009 · 2 comments
Assignees
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

Keith Donald opened SPR-6578 and commented

The ivy says its required to compile.
I think the .pom is wrong.

The result is spring-aop is not included when obtaining spring-context from Maven Central for spring apps; it must be added to pom manually.


Affects: 3.0 GA

Referenced from: commits 38cf127

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

Actually, spring-aop is optional there. spring-context only needs it when building scoped proxies which is an optional feature that needs to be explicitly activated. We may nevertheless decide to mark it as required for convenience but it technically is not.

Juergen

@spring-projects-issues
Copy link
Collaborator Author

Juergen Hoeller commented

I eventually marked spring-aop as required since it is arguably required for several mainstream features in the context package, even if 90% of the context features can be used without spring-aop as well.

Juergen

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: core Issues in core modules (aop, beans, core, context, expression) labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 3.0.1 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants