FormattingConversionServiceFactoryBean.setConverters declares Set<Object> ParameterizedType restricting programmatic usage [SPR-6742]

[spring-projects-issues]

Keith Donald opened SPR-6742 and commented

Shouldn't:

public void setConverters(Set<Object> converters)

be written as:

public void setConverters(Set<? extends Object> converters)

?

With the current declaration, the compiler won't allow me to do something as simple as:

FormattingConversionServiceFactoryBean factory = new FormattingConversionServiceFactoryBean();
Set<MyGenericConverter> converters = Collections.singleton(new MyGenericConverter());
factory.setConverters(converters);

There may be other places in the code base where this is an issue if I recall.

---

Referenced from: commits 6fcca3c

[spring-projects-issues]

Juergen Hoeller commented

Affects the plain ConversionServiceFactoryBean as well. Didn't find any other places in the codebase; we're using Set<?> in similar cases already. Anyway, fixed for 3.0.1.

Juergen