Race condition between AbstractApplicationContext.close() and Spring's shutdownHook [SPR-6793]

[spring-projects-issues]

Liu, Yinwei David opened SPR-6793 and commented

In Spring's AbstractApplicationContext.registerShutdownHook() , it will register a shutdownhook to jvm. however, this shutdownhook is not threadsafe.

If we call AbstractApplicationContext.close(), it will stop all lifecycle beans in its context. however, as soon as all non-daemon threads have been stopped during applictioncontext.close(), jvm will shutdown itself and call shutdownhooks.

The issue is that AbstractApplicationContext.close() will also try to remove the shutdownhook from jvm, so close() will throw one exception java.lang.IllegalStateException: Shutdown in progress.

Could spring fix this issue? thanks.

---

Affects: 3.0 GA

Attachments:

• context.xml (1.07 kB)
• SpringShutdownRaceCondition.java (2.92 kB)

Referenced from: commits 03e9e45, 82178b8

[spring-projects-issues]

Juergen Hoeller commented

Seems that a simple catch (IllegalStateException) block does the trick... Fixed for 3.0.1!

Juergen

[spring-projects-issues]

Liu, Yinwei David commented

Hi Juergen,
Thanks for fixing IllegalStateException issue.
However, I just notice another IllegalStateException issue which causes by this race condition.
In my test case, I have several lifecycle beans. If I stop Spring's application context in a daemon thread which can causes ShutdownHook stop application context again. In the second call, Spring calls DefaultLifecycleProcess.getLifecycleBeans() to stop all lifecycle beans, however, since some lifecycle beans have been destroyed in the first call, so it throws IllegalStateException again to indicate that it cannot get bean because * BeanFactory not initialized or already closed*.

Please see my test case which can throw the exception below:

Exception:
Exception in thread "Thread-0" java.lang.IllegalStateException: BeanFactory not initialized or already closed - call 'refresh' before accessing beans via the ApplicationContext
at org.springframework.context.support.AbstractRefreshableApplicationContext.getBeanFactory(AbstractRefreshableApplicationContext.java:171)
at org.springframework.context.support.AbstractApplicationContext.destroyBeans(AbstractApplicationContext.java:1008)
at org.springframework.context.support.AbstractApplicationContext.doClose(AbstractApplicationContext.java:984)
at org.springframework.context.support.AbstractApplicationContext$3.run(AbstractApplicationContext.java:913)

[spring-projects-issues]

Liu, Yinwei David commented

Test case for java.lang.IllegalStateException: BeanFactory not initialized or already closed

[spring-projects-issues]

Juergen Hoeller commented

Fixed through a dedicated 'closed' flag that we're checking at the beginning of "doClose". This only really affects shutdown hooks since explicit "close()" calls are guarded by the 'startupShutdownMonitor' anyway.

Juergen