Combination of ControllerClassNameHandlerMapping and @RequestMappings with file extensions results in exception [SPR-6906]

[spring-projects-issues]

Arjen Poutsma opened SPR-6906 and commented

When using the ControllerClassNameHandlerMapping in combination with the following controller:

@Controller
public class FooController {
	
	@RequestMapping(value = "{id}", method = RequestMethod.GET)
	public String handleView(Model model, @PathVariable("id") String id) {
	}

	@RequestMapping(value = "{id}.pdf", method = RequestMethod.GET)
	public String handlePdfView(Model model, @PathVariable("id") String id) {
	}
}

Doing a request for /foo/bar works: the id variable is assigned the value bar.
Doing a request for /foo/bar.pdf does not work, and results in an IllegalStateException.

---

Affects: 3.0.1

Referenced from: commits 21fd150, a0c41a0

1 votes, 2 watchers

[spring-projects-issues]

Arjen Poutsma commented

This should be fixed now. Can you please try a recent snapshot and see if it works for you?

[spring-projects-issues]

Daniel Mavis commented

The request /foo/bar.pdf works correctly now, but now the request /foo/bar.do resolves to the @RequestMapping(value = "{id}", method = RequestMethod.GET) with a path variable value of "bar.do", whereas previously it had a value of "bar" (before fix). Not sure if the previous behavior was a bug-feature I was taking advantage of, allowing me not to specify path extensions unless I need to differentiate between different extensions for same resource.

[spring-projects-issues]

Arjen Poutsma commented

Hi Daniel,

Indeed, the previous behavior seems to have been a coincidence of some sorts. That said, you can easily fix the controller to handle both 'bar' and 'bar.do', by using the following mapping:

@RequestMapping(value = {"{id}", "{id}.*"}, method = RequestMethod.GET)

This works in my tests.