Radiobutton/Checkboxes tag doesn't utilize ConversionService for label rendering [SPR-7174]

[spring-projects-issues]

Johnny Zhou opened SPR-7174 and commented

In version 3.0.2, the AbstractMultiCheckedElementTag.java line 291:
tagWriter.appendValue(label.toString());

This line cannot take the advantage of spring conversion service. We should change to the following:
PropertyEditor editor = (value != null ? this.getBindStatus().findEditor(value.getClass()) : null);
String displayString = getDisplayString(label, editor);
tagWriter.appendValue(displayString);

---

Affects: 3.0.2

Attachments:

• AbstractMultiCheckedElementTag.java (9.67 kB)

Referenced from: commits 48869a8, 8ccd74b

[spring-projects-issues]

Johnny Zhou commented

Sorry, the line should be:
PropertyEditor editor = (label != null ? this.getBindStatus().findEditor(label.getClass()) : null);

[spring-projects-issues]

Johnny Zhou commented

search "//Johnny: use convertion service to get label" to get the changes

[spring-projects-issues]

Juergen Hoeller commented

Good point - I've adapted that label rendering code accordingly for Spring 3.0.3.

This will be available in tomorrow's 3.0.3 snapshot. Feel free to give it an early try...

Juergen