Views: setModelKey, setRenderedAttributes should be consistent [SPR-7210]

[spring-projects-issues]

Neale Upstone opened SPR-7210 and commented

The following is required to use ContentNegotiatingViewResolver for XML and JSON.

The two views are inconsistent in how they determine what should be rendered. This could be improved, at least by having them implement one interface and a consistent behaviour, but possibly also by allowing the key to result bean to be specified in the view resolver.

    <bean class="org.springframework.web.servlet.view.ContentNegotiatingViewResolver">
        <property name="order" value="1" />
        <property name="mediaTypes">
            <map>
                <entry key="json" value="application/json" />
                <entry key="xml" value="application/xml" />
            </map>
        </property>
        <property name="defaultViews">
            <list>
                <bean class="org.springframework.web.servlet.view.json.MappingJacksonJsonView" >
                    <property name="renderedAttributes" value="result.key"/>
                </bean>
                <bean class="org.springframework.web.servlet.view.xml.MarshallingView">
                    <property name="modelKey" value="result.key"/>
                    <property name="marshaller" ref="xstreamMarshaller"/>
                </bean>
            </list>
        </property>
        <property name="ignoreAcceptHeader" value="true" />
    </bean>

---

Affects: 3.0.2

Referenced from: commits 5797fe7

[spring-projects-issues]

Rossen Stoyanchev commented

There are important differences to keep in mind. For XML we always render one model attribute. For JSON we can render several. A shared interface is not an option. An attribute on the ViewResolver is even less possible since there are many other view types that don't support similar properties and work differently.

What we can do is add the setters for "modelKey" and "modelKeys" to MappingJacksonJsonView to make it more consistent with the naming in MarshallingView.

[spring-projects-issues]

Neale Upstone commented

Yes. That makes sense.

I'm sure there's a MarshallingView with setModelKey on it in there somewhere ;)