JavaMailSenderImpl should report failedMessages in the event of a network error [SPR-7245]

[spring-projects-issues]

Edd Grant opened SPR-7245 and commented

When sending email in JavaMailSenderImpl, in the event that there are any failed messages the doSend() method includes a Map<MimeMessage, Exception> in the raised MailSendException. This is particularly useful as it allows the caller to identify exactly which emails have failed taking the appropriate action only for those emails.

However if a network problem occurs part way through a send (let's say the socket is closed abnormally) then the MailSendException that is thrown only contains the exception (in this case a SocketException) which has caused the failure.

It would be very useful if the messages which were not sent could be added to the failedMessages Map of the thrown MailSendException along with the causing exception. This would allow the caller to take the appropriate action (which in the case of a network failure might be a delayed retry) for only those messages which were underlivered.

Cheers,

Edd

---

Affects: 2.5.6

Referenced from: commits 433b4ef

[spring-projects-issues]

Juergen Hoeller commented

As far as I can tell, the only case were a MailSendException gets thrown without failed messages is when the connect call fails before even starting to send messages. In other words, if a MailSendException does not come with explicitly listed failed messages, none of the original messages have been sent. That fact should allow for a proper retry strategy: simply assuming that all of the messages will have to be resent...

Juergen

[spring-projects-issues]

Edd Grant commented

We also found that the call to transport.close() causes the MessagingException to be thrown, this then causes a difficulty in knowing whether the exception was thrown upon connection or connection close. It is possible to inspect the exception to find the cause (i.e. ConnectException for failure to connect) but this feels brittle and could, I think, be avoided if all failed messages were populated regardless of the reason for the exception?

[spring-projects-issues]

Juergen Hoeller commented

Alright, as of Spring 3.0.3, MailSendException includes all messages as failed messages in case of a connect() failure, whereas no failed messages will be signalled if transport.close() failed.

Juergen