Document session-scoped proxy serialization issues on Tomcat <= 5.5.25 [SPR-7359]

[spring-projects-issues]

Gerrit Brehmer opened SPR-7359 and commented

When I restarted the server and the current sessions should be serialized to disk, I get an error when serializing a session scoped proxied bean. Is this type of serialization not supported?

Cannot serialize session attribute scoped Target.userSession for session xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
 java.io.NotSerializableException: DefaultListableBeanFactory has no serialization id
       at org.springframework.beans.factory.support.DefaultListableBeanFactory.writeReplace(DefaultListableBeanFactory.java:946)
       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
       at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
       at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
       at java.lang.reflect.Method.invoke(Method.java:585)
       at java.io.ObjectStreamClass.invokeWriteReplace(ObjectStreamClass.java:1004)

---

Affects: 3.0 GA

Reference URL: http://forum.springsource.org/showthread.php?t=88162

This issue is a sub-task of #12102

Issue Links:

• javax.inject.Provider instances injected by container not Serializable [SPR-8002] #12657 javax.inject.Provider instances injected by container not Serializable

3 votes, 2 watchers

[spring-projects-issues]

Gerrit Brehmer commented

second exception:

Cannot serialize session attribute org.springframework.web.context.request.ServletRequestAttributes.DESTRUCTION_CALLBACK.scopedTarget.userSession for session xxxxxxxxxxxxxxxxx
 java.io.NotSerializableException: DefaultListableBeanFactory has no serialization id
       at org.springframework.beans.factory.support.DefaultListableBeanFactory.writeReplace(DefaultListableBeanFactory.java:946)
       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
       at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
       at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
       at java.lang.reflect.Method.invoke(Method.java:585)
       at java.io.ObjectStreamClass.invokeWriteReplace(ObjectStreamClass.java:1004)

[spring-projects-issues]

Juergen Hoeller commented

I wonder which DefaultListableBeanFactory instance this is coming from? Are you bootstrapping such a factory on your own somewhere? If this is the WebApplicationContext's BeanFactory, there should be a serialization id assigned to it...

Juergen

[spring-projects-issues]

Gerrit Brehmer commented

I debugged the server a little bit.

This is the sequence of commands from startup to shutdown/deserialization:

1. DefaultListableBeanFactory.setSerializationId("org.springframework.web.context.WebApplicationContext:context-name")
2. DefaultListableBeanFactory.setSerializationId("org.springframework.web.context.WebApplicationContext:context-name.servlet-name")
3. ---- initiate shutdown ----
4. DispatcherServlet.destroy
   • DefaultListableBeanFactory.setSerializationId(null) (DispatcherServlet BeanFactory)
5. ContextLoaderListener.contextDestroyed
   • DefaultListableBeanFactory.setSerializationId(null) (ContextLoader BeanFactory)
6. StandardSession.writeObjectData()
   • DefaultListableBeanFactory.writeReplace() -> serialization id is null! (on ContextLoader Beanfactory instance)

[spring-projects-issues]

Gerrit Brehmer commented

I looked into the tomcat/catalina sourcecode and found out, that between 5.5.23 and 5.5.29 the order of the steps inside StandardContext was changed:

5.5.23

1. stop children contexts
2. stop filters
3. stop listeners
4. stop sessionmanager

5.5.29

1. stop children contexts
2. stop filters
3. stop sessionmanager
4. stop listeners

So in my case ContextLoaderListener will be stopped before session serialization, but with tomcat 5.5.29 the listener will be stopped after session serialization.

do you know something about this change in the tomcat lifecycle?

[spring-projects-issues]

Juergen Hoeller commented

I haven't heard about that change yet, but I suppose it actually serves your purposes? In other words, does serialization work for you on Tomcat 5.5.29?

Juergen

[spring-projects-issues]

Gerrit Brehmer commented

yes you can close this bug as invalid.
Could you add a hint or known issue with older tomcat versions to the documentation? The lifecycle was changed in 5.5.25.

[spring-projects-issues]

Nikita Tovstoles commented

I am seeing the error on container shutdown with Tomcat 6.0.20 (stack trace below).

Also bean's @PreDestroy method does not get called on container shutdown - is that by design?

Mar 4, 2011 3:11:32 AM org.apache.catalina.core.ApplicationContext log
INFO: Destroying Spring FrameworkServlet 'webapi'
Mar 4, 2011 3:11:33 AM org.apache.catalina.session.StandardSession writeObject
WARNING: Cannot serialize session attribute org.springframework.web.context.request.ServletRequestAttributes.DESTRUCTION_CALLBACK.scopedTarget.sessionAnalyticsData for session 3B9981E6EA152C881C74C8818EB4C950.node0
java.io.NotSerializableException: com.castanealabs.service.analytics.impl.SessionAnalyticsDataHolder
	at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1156)
	at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1509)
	at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1474)
	at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1392)
	at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1150)
	at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1509)
	at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1474)
	at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1392)
	at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1150)
	at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:326)
	at org.apache.catalina.session.StandardSession.writeObject(StandardSession.java:1546)
	at org.apache.catalina.session.StandardSession.writeObjectData(StandardSession.java:989)
	at org.apache.catalina.session.StandardManager.doUnload(StandardManager.java:517)
	at org.apache.catalina.session.StandardManager.unload(StandardManager.java:463)
	at org.apache.catalina.session.StandardManager.stop(StandardManager.java:667)
	at org.apache.catalina.core.StandardContext.stop(StandardContext.java:4611)
	at org.apache.catalina.core.ContainerBase.removeChild(ContainerBase.java:924)
	at org.apache.catalina.startup.HostConfig.undeployApps(HostConfig.java:1319)
	at org.apache.catalina.startup.HostConfig.stop(HostConfig.java:1290)
	at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:323)
	at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:119)
	at org.apache.catalina.core.ContainerBase.stop(ContainerBase.java:1086)
	at org.apache.catalina.core.ContainerBase.stop(ContainerBase.java:1098)
	at org.apache.catalina.core.StandardEngine.stop(StandardEngine.java:448)
	at org.apache.catalina.core.StandardService.stop(StandardService.java:587)
	at org.apache.catalina.core.StandardServer.stop(StandardServer.java:744)
	at org.apache.catalina.startup.Catalina.stop(Catalina.java:648)
	at org.apache.catalina.startup.Catalina.start(Catalina.java:615)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:289)
	at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:414)