DefaultAnnotationHandlerMapping does not allow for distributing Portlet 2.0 action names across controllers [SPR-7685]

[spring-projects-issues]

Jaroslaw Woloch opened SPR-7685 and commented

In spring portlet MVC class DefaultAnnotationHandlerMapping ignore value parameter for @ActionMapping. This parameter contains portlet 2 javax.portlet.ActionRequest#ACTION_NAME value, but 'detectHandlerMethods' ignore it uses only @ActionMappings.params value to match requst params.

Example class:

@Controller
@RequestMapping("VIEV")
class TestController1 {

 @ActionMapping(value = "action1", params = "param1=value1")
    public void testAction(@ModelAttribute(COMMAND_NAME) TestCommand command, ActionResponse response) {
     ...
    }
...
}

@Controller
@RequestMapping("VIEV")
class TestController2 {

 @ActionMapping(value = "action2", params = "param1=value1")
    public void testAction2(@ModelAttribute(COMMAND_NAME) TestCommand command, ActionResponse response) {
     ...
    }
...
}

both action will be mapped as:

param1=value1=TestController1
param1=value1=TestController2

but always first class is used as handler for both url-s:
http://...?...&_testportlet_javax.portlet.action=test1&_testportlet_param1=value1
http://..?...&_testportlet_javax.portlet.action=test2&_testportlet_param1=value1

Example solution for resolve this error:

append @ActionMapping.value as parameter named javax.porlet.ActionRequest.ACTION_NAME to params mapping in method DefaultAnnotationHandlerMapping.detectHandlerMethods(...)

replace this code:

...
else if (ann instanceof EventMapping) {
    EventMapping em = (EventMapping) ann;
    eventName = em.value();
}
else {
    String[] specificParams = (String[]) AnnotationUtils.getValue(ann, "params");
    params = StringUtils.mergeStringArrays(params, specificParams);
							}
...
{/code}

with this:

...
else if (ann instanceof EventMapping) {
EventMapping em = (EventMapping) ann;
eventName = em.value();
}
//this code willbe added to map value as prameter ActionRequest.ACTION_NAME for @ActionMpping
else if (ann instanceof ActionMapping) {
ActionMapping em = (ActionMapping) ann;
String[] action = new String[] {ActionRequest.ACTION_NAME + "=" + em.value()};
params = StringUtils.mergeStringArrays(params, action);
params = StringUtils.mergeStringArrays(params, em.params());
}
else {
String[] specificParams = (String[]) AnnotationUtils.getValue(ann, "params");
params = StringUtils.mergeStringArrays(params, specificParams);
}

---

Affects: 3.0.4, 3.0.5

Referenced from: commits 66b4eb1

4 votes, 4 watchers

[spring-projects-issues]

Jaroslaw Woloch commented

And last one suggestion with this code suggestion.
Add a ActionRequest.ACTION_NAME to params only if @ActionMapping.value is not empty. Then We can define ActionMapping only for params map and not for params map + 'javax.portlet.action='.
ActionRequest.ACTION_NAME is not a required parameter.

I'm lost if condition in example code.

[spring-projects-issues]

Josef Vychtrle commented

Hi, I'd need this bugFix too, could please anybody tell us in which version is this fixed ? In the nightly builds there is not 3.0.6 version . Also if there is a maven repository with nightly builds, it would be highly appreciated. I know only this one http://maven.springframework.org/snapshot/ where the last version is 3.0.4

[spring-projects-issues]

Juergen Hoeller commented

This is more of a known limitation than a bug, actually: DefaultAnnotationHandlerMapping simply doesn't support distributing action names across controllers; it rather expects action requests to be distributed by portlet mode and param conditions, then locally mapped to action names within each controller.

I've revised this for Spring 3.1 now, supporting cross-controller action name mappings even for the same portlet mode and without special param conditions. For completeness, we're supporting the same for render mappings and their window state conditions as well. This will be available in Spring 3.1 GA.

Juergen