ShallowEtagHeaderFilter should make use of specified content length [SPR-8271]

[spring-projects-issues]

Oliver Siegmar opened SPR-8271 and commented

The current ShallowEtagHeaderFilter implementation does not make any use of the content-length set by the content generating code. The attached patch re-initializes the ByteArrayOutputStream with the specified content-length. This improves performance on very busy sites with rather big files.

---

Affects: 3.0.5

Attachments:

• ShallowEtagHeaderFilter-ContentLength.patch (595 bytes)
• ShallowEtagHeaderFilter-ContentLength.patch (511 bytes)

Issue Links:

• ShallowEtagHeaderFilter should not set ETags to non-cached resources [SPR-11110] #15736 ShallowEtagHeaderFilter should not set ETags to non-cached resources
• ShallowEtagHeaderFilter setContentLength on include [SPR-11717] #16339 ShallowEtagHeaderFilter setContentLength on include
• ShallowEtagHeaderFilter doesn't support Servlet 3.1 setContentLengthLong [SPR-12097] #16713 ShallowEtagHeaderFilter doesn't support Servlet 3.1 setContentLengthLong
• ShallowEtagHeaderFilter should use a more efficiently dynamically resizing buffer than ResizableByteArrayOutputStream [SPR-12081] #16697 ShallowEtagHeaderFilter should use a more efficiently dynamically resizing buffer than ResizableByteArrayOutputStream
• ResizableByteArrayOutputStream and ByteArrayOutputStream capacities [SPR-11594] #16218 ResizableByteArrayOutputStream and ByteArrayOutputStream capacities
• Extract ContentCachingRequestWrapper and ContentCachingResponseWrapper for custom use outside of Spring's filters [SPR-12477] #17083 Extract ContentCachingRequestWrapper and ContentCachingResponseWrapper for custom use outside of Spring's filters

Referenced from: commits ae012ae

2 votes, 4 watchers

[spring-projects-issues]

Oliver Siegmar commented

Same patch with fully qualified directory based on trunk.

[spring-projects-issues]

Eugen Paraschiv commented

This would also make sense from the POV of the consumer, which should see the Content-Lenght: 0, which does not happen now:

HTTP/1.1 304 Not Modified
Server: Apache-Coyote/1.1
ETag: "03cb37ca667706c68c0aad4cb04c3a211"
Date: Fri, 11 Jan 2013 13:56:20 GMT

[spring-projects-issues]

Stevo Slavić commented

"Fix version" is not filled.