Allow RedirectView to expose a bookmarkable URL [SPR-8431]

[spring-projects-issues]

!!Use pwebb rather than philw opened SPR-8431 and commented

In order to provide deeper integration between Spring and JSF I would like it if RedirectView could expose a bookmark string. This would allow me to implement JSFs ViewHandler.getBookmarkableURL using MVC views.

Attached is a patch that provides a new BookmarkableView interface and modifies RedirectView to implement it. I have also updated the test case.

---

Affects: 3.1 M2

Attachments:

• bookmarkable.patch (9.17 kB)

Referenced from: commits a58bd30

[spring-projects-issues]

Rossen Stoyanchev commented

From a brief look it looks like you just need a way to access to the target URL prepared by RedirectView? If so we can make that improvement as it goes along with #7380 which was resolved in 3.1 M2. I'm putting it on the 3.1 backlog for now.

[spring-projects-issues]

Rossen Stoyanchev commented

I've added RedirectView#createTargetUrl(..) and AbstractView#createMergedOutputModel(..). Between these methods you should be able to get the URL but you'll need to extend RedirectView. Since it only requires a couple of lines of code it could even be done in an anonymous class.

[spring-projects-issues]

!!Use pwebb rather than philw commented

Thanks Rossen, that change should help a lot.

One slight complication I still have is that RedirectViews are often created from "redirect:someurl" Strings by the UrlBasedViewResolver. With RedirectView#createTargetUrl being protected I will need to register my own resolver to create the subclassed RedirectView. It's not a big deal but having createTargetUrl being public would be nicer for me (but of course I understand if you want to keep this internal).

BTW: The patch also included a pathVariable test, it's not really related to creating bookmark strings just adds a bit more coverage.

Cheers,
Phil.

[spring-projects-issues]

Rossen Stoyanchev commented

Without an interface making this method public would be odd since the View contract is the only public interface. And a BookmarkableUrlView as a concept it just isn't obvious how it fits in Spring MVC view rendering and what can be used for.

BTW we do have URI template variable tests in a separate test fixture RedirectViewUriTemplateTests.

[spring-projects-issues]

!!Use pwebb rather than philw commented

Oh sorry, I totally missed those tests. I feel a bit stupid now :)

I think you are totally correct about BookmarkableUrlView, it feels like a kludge just for me and is probably best kept out of the core.

Also fair enough if you think making createTargetUrl() public is not wise, the additional resolver is not a big deal. The only advantage for me would be that I could create a simple adapter class to convert RedirectView to a BookmarkableUriView.

Thanks again for fix, I realise it's a fairly minor issue so I really appreciate it.

Phil.