@PathVariable values sent as query parameters in redirect unexpectedly [SPR-8448]

[spring-projects-issues]

Keith Donald opened SPR-8448 and commented

I have a '@PathVariable String providerId' MethodParameter declaration on a @Controller that returns a RedirectView. The redirect is sent with s 'providerId=<value>' query parameter present in the URL, which was not expected or needed. I consider this a bug because in my case this behavior pollutes the URL the end-user sees with a parameter that is not needed/relevant.

---

Affects: 3.1 M2

[spring-projects-issues]

Rossen Stoyanchev commented

Keith, what does the redirect URL look like? And do you rely on appending any query string parameters?

1. Model attributes used as template variables are not appended - e.g given "foo=1" and redirect string "redirect:/{foo}/bar", the resulting redirect is "/1/bar".

2. RedirectView has a constructor arg to turn off automatic appending entirely.

Also 1) and 2) can be combined. For example "redirect:/someUrl?foo={foo}&bar={bar}" with automatic appending turned off.

[spring-projects-issues]

Keith Donald commented

RedirectView just returns a String URL with no url template variables. No, I do not rely on appending anything, and don't expect appending to be done for something I did not add to the model myself. providerId=value gets appended to this URL before the redirect is sent. This is easy to see by running the spring-social-quickstart or Greenhouse or any other app using 3.1 and redirect views.

[spring-projects-issues]

Rossen Stoyanchev commented

Path variables are no longer added to the model for RedirectView. However URI template variables from the current request can be used as URI template variables in the redirect string.