Support comments within SQL statements in ResourceDatabasePopulator [SPR-10075]

[spring-projects-issues]

Sam Brannen opened SPR-10075 and commented

Status Quo

The deficiency addressed by this issue is the same as that described in #14616 but for ResourceDatabasePopulator.

Deliverables

Refactor ResourceDatabasePopulator.splitSqlScript(String, String, String, List) so that:

1. Standard SQL comments (i.e., any text beginning with two hyphens and extending to the end of the line) are properly omitted from the statement before executing it.
2. Multiple adjacent whitespace characters within a statement but outside a literal are collapsed into a single space.

---

Affects: 3.1.3

Issue Links:

• Support comments within SQL statements in JdbcTestUtils [SPR-9982] #14616 Support comments within SQL statements in JdbcTestUtils
• Support multi-line SQL comments in ResourceDatabasePopulator and JdbcTestUtils [SPR-9531] #14165 Support multi-line SQL comments in ResourceDatabasePopulator and JdbcTestUtils

Referenced from: commits 8a422f4, aa16caa

[spring-projects-issues]

Sam Brannen commented

Resolved as described in the comments for GitHub commit aa16caa2ac:

Support comments in statements in RDbPopulator

Prior to this commit, executing an SQL script via
ResourceDatabasePopulator would fail if a statement in the script
contained a line comment within the statement.

This commit ensures that standard SQL comments (i.e., any text beginning
with two hyphens and extending to the end of the line) are properly
omitted from the statement before executing it.

In addition, multiple adjacent whitespace characters within a statement,
but outside a literal, are now collapsed into a single space.