@RequestMapping no longer agnostic about URL path parameters [SPR-10234]

[spring-projects-issues]

Anthony Gerrard opened SPR-10234 and commented

@RequestMapping("/something")

used to match

/something;else=true

in Spring 3.1. In Spring 3.2 you now get a 404 not found. This is inconsistent with the behaviour demanded in the servlet 3.0 specification (not sure if this counts for anything)

The path used for mapping to a servlet is the request URL from the request object minus the context path and the path parameters

I notice jsessionid path parameters are still ignored.

---

Affects: 3.2 GA

Issue Links:

• A URI with URL path parameters causes IllegalStateException [SPR-10427] #15060 A URI with URL path parameters causes IllegalStateException ("is superseded by")

Referenced from: commits 9c19469, 5b1165b, d23de28

[spring-projects-issues]

Rossen Stoyanchev commented

By default we still remove semicolon content. However, if using the MVC Java config or the MVC namespace, the more opinionated configuration options, the default has changed in order to support matrix variables. The property that controls this is removeSemicolonContent on UrlPathHelper, which itself is a property of RequestMappingHandlerMapping.

You can also add a URI variable or a pattern (e.g. "/something{else}").

[spring-projects-issues]

Anthony Gerrard commented

I hadn't realized the URL path parameters are also called matrix variables. This is a neat new feature but I'd have expected it to work like query string parameters work: if they are not mentioned in the request mapping then it matches. It seems to me that you shouldn't need to add a URI variable for path parameters to be ignored.

"/something" should continue to match /something;else=true

[spring-projects-issues]

Rossen Stoyanchev commented

That's a good point. It might be a little tricky to do without introducing other side effects but will give it a try at least for 3.2.2.

Note also that path parameters were never completely ignored in the past, but simply truncated at the first semicolon. So only the last path segment could have them.

[spring-projects-issues]

Rossen Stoyanchev commented

This is now resolved 5b1165b1029263ff0020562da95bd30380f303e4

[spring-projects-issues]

Anthony Gerrard commented

I'm not sure this is fixed at least I now get a 500 internal server error where in Spring 3.1 it served the page just fine:

org.springframework.web.util.NestedServletException: Request processing failed; nested exception is java.lang.IllegalStateException: Pattern "/donate" is not a match for "/donate;v1=1"
org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:948)
org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:827)
javax.servlet.http.HttpServlet.service(HttpServlet.java:621)
org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:812)
javax.servlet.http.HttpServlet.service(HttpServlet.java:728)
com.opensymphony.sitemesh.webapp.SiteMeshFilter.obtainContent(SiteMeshFilter.java:129)
com.opensymphony.sitemesh.webapp.SiteMeshFilter.doFilter(SiteMeshFilter.java:77)
org.springframework.web.filter.CharacterEncodingFilter.doFilterInternal(CharacterEncodingFilter.java:88)
org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)

root cause

java.lang.IllegalStateException: Pattern "/donate" is not a match for "/donate;v1=1"
org.springframework.util.Assert.state(Assert.java:385)
org.springframework.util.AntPathMatcher.extractUriTemplateVariables(AntPathMatcher.java:287)
org.springframework.web.servlet.mvc.method.RequestMappingInfoHandlerMapping.handleMatch(RequestMappingInfoHandlerMapping.java:102)
org.springframework.web.servlet.mvc.method.RequestMappingInfoHandlerMapping.handleMatch(RequestMappingInfoHandlerMapping.java:54)
org.springframework.web.servlet.handler.AbstractHandlerMethodMapping.lookupHandlerMethod(AbstractHandlerMethodMapping.java:285)
org.springframework.web.servlet.handler.AbstractHandlerMethodMapping.getHandlerInternal(AbstractHandlerMethodMapping.java:229)
org.springframework.web.servlet.handler.AbstractHandlerMethodMapping.getHandlerInternal(AbstractHandlerMethodMapping.java:56)
org.springframework.web.servlet.handler.AbstractHandlerMapping.getHandler(AbstractHandlerMapping.java:298)
org.springframework.web.servlet.DispatcherServlet.getHandler(DispatcherServlet.java:1091)
org.springframework.web.servlet.DispatcherServlet.getHandler(DispatcherServlet.java:1076)
org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:896)
org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:856)
org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:936)
org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:827)
javax.servlet.http.HttpServlet.service(HttpServlet.java:621)
org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:812)
javax.servlet.http.HttpServlet.service(HttpServlet.java:728)
com.opensymphony.sitemesh.webapp.SiteMeshFilter.obtainContent(SiteMeshFilter.java:129)
com.opensymphony.sitemesh.webapp.SiteMeshFilter.doFilter(SiteMeshFilter.java:77)
org.springframework.web.filter.CharacterEncodingFilter.doFilterInternal(CharacterEncodingFilter.java:88)
org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)

[spring-projects-issues]

Rossen Stoyanchev commented

Anthony Gerrard, apologies for this additional problem! I've created #15060 to track it and will close this ticket.