Infinite Recursion in org.springframework.core.ResolvableType.hashCode(ResolvableType.java:692) [SPR-11219]

[spring-projects-issues]

Russ Tennant opened SPR-11219 and commented

We're getting a StackOverflowError during dependency injection.

 
Caused by: java.lang.StackOverflowError
	at java.lang.reflect.InvocationTargetException.<init>(InvocationTargetException.java:72)
	at sun.reflect.GeneratedMethodAccessor2.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at org.springframework.core.SerializableTypeWrapper$TypeProxyInvocationHandler.invoke(SerializableTypeWrapper.java:220)
	at com.sun.proxy.$Proxy4.hashCode(Unknown Source)
	at org.springframework.util.ObjectUtils.nullSafeHashCode(ObjectUtils.java:336)
	at org.springframework.core.ResolvableType.hashCode(ResolvableType.java:692)
	at org.springframework.util.ObjectUtils.nullSafeHashCode(ObjectUtils.java:336)
	at org.springframework.core.ResolvableType.hashCode(ResolvableType.java:693)

The class that is triggering the issue is ITableColumnScriptableType which has this hierarchy.

public class ITableColumnScriptableType extends JSR223LibraryType<ITableColumnScriptableType>

public abstract class JSR223LibraryType<LT extends JSR223LibraryType<LT>> extends AbstractLibraryType<LT>

public abstract class AbstractLibraryType<LT extends AbstractLibraryType<LT>> implements ILibraryType<LT>

public interface ILibraryType<LT extends ILibraryType<LT>>

This did not occur in version 3.2.5.

Attached is the error log from the StackOverflowError and a thread dump taken before the stack overflow.

---

Affects: 4.0 GA

Attachments:

• error-log.txt (174.96 kB)
• spr11219-test-case.zip (5.16 kB)
• spr11219-test-case-2.zip (5.17 kB)
• threads_report.txt (58.15 kB)

Referenced from: commits 994efe4, aa2fadd

[spring-projects-issues]

Juergen Hoeller commented

I've revised ResolvableType's hashCode/equals implementation to explicitly avoid such infinite recursions. However, I haven't been able to reproduce the demonstrated problem in a unit test; I had to hack ResolvableType to actually produce a self-reference that leads to such a StackOverflowError. The current revision fixes the problem in that hacked scenario at least.

It would be great if you could give a 4.0.1 snapshot a try (see http://projects.spring.io/spring-framework/ for repo details) to verify that the fix actually solves the problem in your scenario.

Juergen

[spring-projects-issues]

Russ Tennant commented

Test case.

[spring-projects-issues]

Russ Tennant commented

It still happens with the 4.0.1 snapshot for me.

I created a test case to help in reproducing the issue. See attached spr11219-test-case.zip. Running the SPR1129Test class reproduced the issue for me. Let me know if there is anything else I can do to help. Thanks.

[spring-projects-issues]

Juergen Hoeller commented

Thanks, that will help...

[spring-projects-issues]

Russ Tennant commented

New zip:
Fixed class name - misspelled.
Fixed to run under 3.2.6.
Infinite recursion still occurs under 4.

[spring-projects-issues]

Juergen Hoeller commented

Good news: I managed to get down to the root cause of your scenario which lies in an infinite recursion when resolving a left-hand-side type variable in isAssignableFrom. This only really started showing once hashCode/equals didn't cause any infinite recursions of their own anymore. It's fixed now; just an infinite recursion in toString() left - only showing if somebody logs a ResolvableType or otherwise explicitly calls toString(). I'll mark this issue as resolved once that part is addressed as well.

Juergen

[spring-projects-issues]

Juergen Hoeller commented

A rather extensive revision is pushed now and will be available in the next 4.0.1 snapshot. Your submitted test cases passes but feel free to verify yourself.

Juergen