Spring4 MVC Unit test does not compile [SPR-11238]

[spring-projects-issues]

Kent Yeh opened SPR-11238 and commented

I have same problem
when I running under jdk 1.6.0_33 with error

[INFO] -------------------------------------------------------------
[WARNING] COMPILATION WARNING : 
[INFO] -------------------------------------------------------------
[WARNING] /mavenrepository/org/springframework/spring-context/4.0.0.RELEASE/spring-context-4.0.0.RELEASE.jar!org/springframework/scheduling/annotation/Scheduled.class: org/springframework/scheduling/annotation/Scheduled.class(org/springframework/scheduling/annotation:Scheduled.class): warning: Cannot find annotation method 'value()' in type 'java.lang.annotation.Repeatable': class file for java.lang.annotation.Repeatable not found
[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] /ttsrc/git/kmlgen/src/test/java/kml/controller/TestDefaultController.java:[81,42] incompatible types; inferred type argument(s) java.lang.Object do not conform to bounds of type variable(s) B
found   : <B>org.springframework.test.web.servlet.setup.DefaultMockMvcBuilder<B>
required: java.lang.Object

---

Affects: 4.0 GA

Reference URL: http://stackoverflow.com/questions/20574894/spring4-mvc-unit-test-does-not-compile

Attachments:

• test4spring4.zip (46.87 kB)

Issue Links:

• MVC Test: compile issue when using MockMvcBuilders.webAppContextSetup(...).build() [SPR-11283] #15907 MVC Test: compile issue when using MockMvcBuilders.webAppContextSetup(...).build() ("is duplicated by")

Referenced from: commits 2e4f38f

0 votes, 6 watchers

[spring-projects-issues]

Rossen Stoyanchev commented

There was indeed a comprehensive update to fix compiler warnings around missing generics.

I am actually unable to reproduce the issue with the Spring MVC Showcase tests. See for example ViewControllerTests as well as many others. I tried with both Java 1.7 and 1.6 ("1.6.0_32-ea").

Is it possible that you have both 4.0 and 3.2.5 on the classpath? If using maven you can do mvn dependency:tree to verify or with gradle use the dependencies task.

/cc Phil Webb

[spring-projects-issues]

Kent Yeh commented

Attachment can reproduce test compile error

[spring-projects-issues]

Rossen Stoyanchev commented

Thanks, I can see the compile error when using jdk 1.6. Not sure why I don't see it with the spring-mvc-showcase but at least we have something now. I've created an issue project from the attached sources.

[spring-projects-issues]

Kent Yeh commented

Rossen
I found even the most simple java cannot pass compile.

public class App {
     static <B extends DefaultMockMvcBuilder<B>> DefaultMockMvcBuilder<B> webAppContextSetup() {
        return new DefaultMockMvcBuilder<B>();
    }
    public static void main(String[] args) {
        System.out.println(webAppContextSetup().msg());
    }
    static class DefaultMockMvcBuilder<B extends DefaultMockMvcBuilder<B>> {
        public String msg() {
            return getClass().getName();
        }
    }
}

App.java:6: incompatible types; inferred type argument(s) java.lang.Object do not conform to bounds of type variable(s) B
found   : <B>App.DefaultMockMvcBuilder<B>
required: java.lang.Object
        System.out.println(webAppContextSetup().msg());
                                ^
1 error

I don't known how could your jdk 6 do?
My JDK info is

java -version
Picked up _JAVA_OPTIONS: -Dawt.useSystemAAFontSettings=lcd
java version "1.6.0_33"
Java(TM) SE Runtime Environment (build 1.6.0_33-b03)
Java HotSpot(TM) 64-Bit Server VM (build 20.8-b03, mixed mode)

[spring-projects-issues]

Rossen Stoyanchev commented

See commit 2e4f38.

[spring-projects-issues]

Sridharan Kuppa commented

As per the status it is closed but I am getting still getting the warning during compilation.

/home/kuppas/.gradle/caches/modules-2/files-2.1/org.springframework/spring-context/4.0.3.RELEASE/782a71a312dc307fa531023aa66247b9b4a109d/spring-context-4.0.3.RELEASE.jar(org/springframework/scheduling/annotation/Scheduled.class): warning: Cannot find annotation method 'value()' in type 'Repeatable': class file for java.lang.annotation.Repeatable not found
/home/kuppas/.gradle/caches/modules-2/files-2.1/org.springframework/spring-context/4.0.3.RELEASE/782a71a312dc307fa531023aa66247b9b4a109d/spring-context-4.0.3.RELEASE.jar(org/springframework/scheduling/annotation/Scheduled.class): warning: Cannot find annotation method 'value()' in type 'Repeatable': class file for java.lang.annotation.Repeatable not found
/home/kuppas/.gradle/caches/modules-2/files-2.1/org.springframework/spring-context/4.0.3.RELEASE/782a71a312dc307fa531023aa66247b9b4a109d/spring-context-4.0.3.RELEASE.jar(org/springframework/scheduling/annotation/Scheduled.class): warning: Cannot find annotation method 'value()' in type 'Repeatable': class file for java.lang.annotation.Repeatable not found
/home/kuppas/.gradle/caches/modules-2/files-2.1/org.springframework/spring-context/4.0.3.RELEASE/782a71a312dc307fa531023aa66247b9b4a109d/spring-context-4.0.3.RELEASE.jar(org/springframework/scheduling/annotation/Scheduled.class): warning: Cannot find annotation method 'value()' in type 'Repeatable': class file for java.lang.annotation.Repeatable not found

Looking at the source code from github,
https://github.com/spring-projects/spring-framework/blob/master/spring-context/src/main/java/org/springframework/context/annotation/PropertySource.java#L147

I can confirm that this needs to fixed.

Thanks,
-Sridharan

[spring-projects-issues]

Sam Brannen commented

Sridharan Kuppa, this issue was about a "COMPILATION ERROR", not a warning.

The compilation error has been fixed, and that is why this JIRA issue has been closed.

You can ignore the warning about "class file for java.lang.annotation.Repeatable not found". @Repeatable is only supported on Java 8+, but its presence on Spring classes will not adversely affect your application code compiled or executed against Java 6 or 7.

Regards,

Sam