Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarshallingView should not close response output stream [SPR-11411] #16038

Closed
spring-projects-issues opened this issue Feb 10, 2014 · 0 comments
Closed

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Feb 10, 2014

Roberto Franchini opened SPR-11411 and commented

The method renderMergedOutputModel should not close the HttpServletResponse output stream.
The called utility method
FileCopyUtils.copy(bos.toByteArray(), response.getOutputStream());
closes the stream avoiding other output filters adding more informations.

Use streamUtils instead

For example, if the view is invoked by a url under security, the session id cookie isn't sent back to the client.


Affects: 3.1.2, 4.0.1

Issue Links:

  • #16040 Consistently avoid close() call on Servlet OutputStream
  • #16269 MarshallingView should avoid temporary byte array when copying to response

Referenced from: commits 648245b, b223e6e

Backported to: 3.2.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants