Cannot add script after setting scripts in ResourceDatabasePopulator [SPR-11691]

[spring-projects-issues]

Sam Brannen opened SPR-11691 and commented

Status Quo

The setScripts() method in ResourceDatabasePopulator replaces the internal scripts array with a value returned from Arrays.asList() which is an unmodifiable List. Consequently, it is impossible to add additional scripts to a ResourceDatabasePopulator after setScripts() has been invoked.

For example, the following test fails with an UnsupportedOperationException.

public class ResourceDatabasePopulatorTests {

	private Resource script1 = resource("script1");
	private Resource script2 = resource("script2");
	private Resource script3 = resource("script3");

	@Test
	public void setScriptsAndThenAddScript() {
		ResourceDatabasePopulator databasePopulator = new ResourceDatabasePopulator();
		databasePopulator.setScripts(script1, script2);

		// Throws UnsupportedOperationException
		databasePopulator.addScript(script3);
	}

	private Resource resource(String path) {
		return new ClassPathResource(path);
	}

}

---

Deliverables

1. Ensure that scripts can be added to a ResourceDatabasePopulator after the setScripts() method has been invoked.

---

Affects: 3.2 GA

Referenced from: commits b4995f7

[spring-projects-issues]

Sam Brannen commented

Fixed as described in the comments for GitHub commit b4995f7:

Add script after setting scripts in RsrcDbPopultr

Prior to this commit it was impossible to add additional scripts to a
ResourceDatabasePopulator after setScripts() had been invoked.

This commit fixes this by ensuring that the internal scripts list
continues to be modifiable when setScripts() is invoked.