Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completion callbacks (regardless of failure) to ChannelInterceptor [SPR-11967] #16583

Closed
spring-projects-issues opened this issue Jul 7, 2014 · 1 comment
Assignees
Labels
in: messaging type: task
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Jul 7, 2014

Rob Winch opened SPR-11967 and commented

A ChannelInterceptor may need to be invoked in all cases, even failure, after the message is sent for example to clear thread local context.

The specific use case is for Spring Security to be able to set up the SecurityContextHolder in preSend and then clear it regardless of whether the send succeeded or failed.


Affects: 4.0.5

This issue is a sub-task of #16582

Issue Links:

  • SEC-2672 ChannelInterceptorAdapter not reliable to clear SecurityContextHolder ("is depended on by")
  • INT-2166 Adding support for SecurityContext Propagation
@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jul 9, 2014

Rossen Stoyanchev commented

Marking as resolved since the ChannelInterceptor additional callbacks have been added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: messaging type: task
Projects
None yet
Development

No branches or pull requests

2 participants