Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SocketUtils should not be an abstract class [SPR-12169] #16783

Closed
2 tasks done
spring-projects-issues opened this issue Sep 9, 2014 · 3 comments
Closed
2 tasks done

SocketUtils should not be an abstract class [SPR-12169] #16783

spring-projects-issues opened this issue Sep 9, 2014 · 3 comments
Assignees
Labels
in: core status: backported type: bug
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Sep 9, 2014

Sam Brannen opened SPR-12169 and commented

Status Quo

Per the Javadoc for the SocketUtils() constructor, SocketUtils can be instantiated as a Spring Bean in XML configuration files; however, SocketUtils is currently abstract which prevents such usage.

Deliverables

  1. Make SocketUtils a concrete class
  2. Backport to Spring Framework 4.0.8

Affects: 4.0 GA

Backported to: 4.0.8

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Sep 9, 2014

Sam Brannen commented

Completed as described in the comments for GitHub commit 559e81b:

Make SocketUtils a concrete class

Per the Javadoc for the SocketUtils() constructor, SocketUtils can be
instantiated as a Spring Bean in XML configuration files; however,
SocketUtils is currently abstract which prevents such usage.

This commit removes the 'abstract' declaration thereby allowing
SocketUtils to be instantiated as a Spring bean.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Sep 9, 2014

Sam Brannen commented

Reopened for backporting to 4.0.8.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Sep 17, 2014

Sam Brannen commented

Juergen Hoeller, thanks for backporting that for me. ;)

@spring-projects-issues spring-projects-issues added type: bug status: backported in: core labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.1.1 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core status: backported type: bug
Projects
None yet
Development

No branches or pull requests

2 participants