Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Async responses force concurrentResult.toString() call [SPR-12253] #16867

spring-projects-issues opened this issue Sep 26, 2014 · 1 comment
in: web status: backported type: bug


Copy link

@spring-projects-issues spring-projects-issues commented Sep 26, 2014

Ryszard Perkowski opened SPR-12253 and commented

I've been tracking CPU usage of my application and multiple times have I seen in thread dump whole response object string concatenation (toString() method called) taking a lot of CPU.
That string concatenation is forced by using
logger.debug("Concurrent result value [" + concurrentResult + "]");

Since it's only for debug it should not be executed for other logging levels.

Pull request provided:

Affects: 3.2.11, 4.0.7, 4.1 GA

Backported to: 4.0.8, 3.2.12

Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Sep 26, 2014

Juergen Hoeller commented

Fixed, and WebAsyncManager also builds correct DeferredResultProcessingInterceptor keys now (derived from interceptor instance instead of array instance).


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
in: web status: backported type: bug
None yet

No branches or pull requests

2 participants