Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making it easier to replace "RequestMappingHandlerAdapter.handleInternal" [SPR-12460] #17065

Closed
spring-projects-issues opened this issue Nov 21, 2014 · 0 comments
Assignees
Labels
in: web status: backported type: enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Nov 21, 2014

Fabio Tudone opened SPR-12460 and commented

For a Spring Boot integration with a container not based on threads, in "RequestMappingHandlerAdapter.handleInternal" I need to use a different synchronization mechanism rather than "synchronized" but the method is "final". Actually "AbstractHandlerMethodAdapter.handle" is "final" too, so I can't redirect the call somewhere else in a "RequestMappingHandlerAdapter" subclass: I'd need to mirror the whole hierarchy and reconfigure Spring to use my own (unless I'm missing a more straightforward way, in which case I'd be very grateful if you could point me to it).

Would it be possible to ease this restriction?


Affects: 4.0.8, 4.1.2

Reference URL: https://github.com/spring-projects/spring-framework/blob/master/spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/RequestMappingHandlerAdapter.java#L698

Issue Links:

  • #17090 Allow overriding InvocableHandlerMethod.invoke and/or ServletInvocableHandlerMethod.invokeAndHandle in subclasses

Referenced from: commits f093a5f, ece2c90

Backported to: 4.0.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web status: backported type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants