Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow easier use of custom RequestMappingHandlerMapping in WebMvcConfigurationSupport [SPR-12746] #17343

Closed
spring-issuemaster opened this issue Feb 23, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Feb 23, 2015

Ryan Skow opened SPR-12746 and commented

The ability to customize RequestMappingHandlerMapping by overriding protected methods was added in #12468. However, WebMvcConfigurationSupport instantiates its own RequestMappingHandlerMapping and configures it with default settings all in a single method. This makes it hard to extend WebMvcConfigurationSupport to make it return an extension of RequestMappingHandlerMapping without copying and pasting a substantial chunk of code (in the requestMappingHandlerMapping() method).

It would be simple to extract the addition of the default configuration to RequestMappingHandlerMapping to a separate method, allowing extenders to avoid this duplication of internal Spring logic. A pull request will follow this issue.


Affects: 4.1.5

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 23, 2015

Ryan Skow commented

Pull request: #744

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.