ProtobufHttpMessageConverter support for protobuf 3.0.0-beta4 [SPR-13589]

[spring-projects-issues]

Brian Clozel opened SPR-13589 and commented

Google protobuf is now 3.0.0-beta4 and is backing the new grpc project.

Let's update our ProtobufHttpMessageConverter to also support this upcoming version.

In the meantime the protobuf-java-format has moved to github and had two new releases with potential breaking changes. This issue should also deal with those.

---

Issue Links:

• Upgrade to Protobuf Java Format 1.4 [SPR-14171] #18743 Upgrade to Protobuf Java Format 1.4
• ProtobufHttpMessageConverter: JSON not written to response [SPR-15988] #20538 ProtobufHttpMessageConverter: JSON not written to response
• HttpMessageConverter based on Protostuff library [SPR-13203] #17795 HttpMessageConverter based on Protostuff library
• ProtobufHttpMessageConverter: Make JSON format configurable [SPR-15550] #20109 ProtobufHttpMessageConverter: Make JSON format configurable

Referenced from: commits 4d035e3

2 votes, 8 watchers

[spring-projects-issues]

Brian Clozel commented

hakamairi, thanks for pointing out the new releases of com.googlecode.protobuf-java-format.
Now I'd like to know more about those new releases hoted on https://github.com/bivas/protobuf-java-format; were those done by the former maintainers of the project, or is this a fork maintained by the community? Are you involved in this?

As you can see, this issue aims at making the support of additional formats more flexible. Not only supporting com.googlecode.protobuf-java-format but also com.google.protobuf.protobuf-java.

Now I might consider those new releases (and breaking changes) for Spring 4.3, I just need to know what those changes involve. Do those changes require some actions from the developers using this library, or are those changes just internal to Spring support?

[spring-projects-issues]

hakamairi commented

Brian Clozel Unfortunately I'm not involved in the project.
From what I've seen in the git repository's code they introduced the pull requests that were added post mortem to original project and kept developing it further.

The breaking changes I get in my code is JsonFormat.print not being static anymore (which I basically use only for testing).

Most important they are actively developing ;)

[spring-projects-issues]

Brian Clozel commented

Apparently the owner of the project forked it to github, so not a fork per se...
Because those changes are breaking, I'll schedule those changes as part of this issue for Spring 4.3. I'll see if this requires raising the minimum requirement for the library version.

Thanks!

[spring-projects-issues]

Brian Clozel commented

Work is almost complete here.

Still waiting for the official release, which is not scheduled yet. Two new betas should be published in the next weeks, see the protobuf github milestone page.

I've raised the requirement for "com.googlecode.protobuf-java-format:protobuf-java-format" to 1.3+ (1.4 is already out) as breaking changes happened and the previous 1.2 version dates back to May 2011...

[spring-projects-issues]

Brian Clozel commented

Still no release, nor beta version. Pushing this back to RC2.

[spring-projects-issues]

Juergen Hoeller commented

Protobuf 3.0 beta 4 is out, and they seem to be aiming towards GA next. Brian Clozel, maybe a good time to roll your branch into 5.0 M1 already?

[spring-projects-issues]

Ondřej Burkert commented

Just a note. Protobuf 3.0 is out (https://github.com/google/protobuf/releases/tag/v3.0.0).

If I read it correctly here the only way to get that running with Spring 5.0 M1, correct?

[spring-projects-issues]

Brian Clozel commented

Yes, protobuf 3 is supported as of Spring 5 (i.e. not supported with Spring 4)

[spring-projects-issues]

Ondřej Burkert commented

Thanks for confirmation.