SockJS / XHR Polling does not reset connection for heartbeat [SPR-14107]

[spring-projects-issues]

Good Code opened SPR-14107 and commented

In AbstractHttpSockJsSession, writeFrameInternal method:

The final this.response.flush(); call is insufficient to reset the polling connection for heartbeat. Should be something like resetRequest(); as in the 4.1.9 release.

Possibly we meant to call flushCache() in PollingSockJsSession?

---

Affects: 4.2.1, 4.2.2, 4.2.3, 4.2.4, 4.2.5

Referenced from: commits cfdb683, 000a0a0

[spring-projects-issues]

Rossen Stoyanchev commented

Certainly needs fixing. I'm wondering how did you come across this, i.e. was there some side effect or just looking at the code?