Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SockJS / XHR Polling does not reset connection for heartbeat [SPR-14107] #18679

Closed
spring-issuemaster opened this issue Apr 1, 2016 · 1 comment
Closed
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Apr 1, 2016

Good Code opened SPR-14107 and commented

In AbstractHttpSockJsSession, writeFrameInternal method:

The final this.response.flush(); call is insufficient to reset the polling connection for heartbeat. Should be something like resetRequest(); as in the 4.1.9 release.

Possibly we meant to call flushCache() in PollingSockJsSession?


Affects: 4.2.1, 4.2.2, 4.2.3, 4.2.4, 4.2.5

Referenced from: commits cfdb683, 000a0a0

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Apr 4, 2016

Rossen Stoyanchev commented

Certainly needs fixing. I'm wondering how did you come across this, i.e. was there some side effect or just looking at the code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.