Combine @PathParam with @RequestBody [SPR-14149]

[spring-projects-issues]

Suresh opened SPR-14149 and commented

xpI am using spring boot as RESTFul service. I have a requirement to combine @PathParam value with @RequestBody POJO.

The reason is, I am using hibernate validator to validate the POJO. I can manually merge @PathParam values in Controller class but the hibernate validator is called before the merge happens.

*Example:
I have a POJO as defined below.

public Class User{
  private String id;
  private String name;
  private String firstName;
....
}

Resource class as defined below:

@RestController
@RequestMapping(value = "user")
public Class UserResource{

  @RequestMapping(value = "{id}", method = RequestMethod.PUT)
  public String update(@PathVariable String id, @RequestBody @Validated(UpdateValidator.class) User user){
    user.setId(id);// Have to avoid this.
    service.update(user);
  }
}

---

No further details from SPR-14149

[spring-projects-issues]

Rossen Stoyanchev commented

I don't see a clear cut solution for this in the general case, overlaying the de-serialized request body with path variables. It's bound to lead to surprises. It seems to me however that the the UpdateValidator should be in sync with the expected input. In other words either expect the id to be in the body or don't validate it. Beyond that it's not very hard to create a custom argument resolver that combines the behaviors. As I said I just don't see that working out more generally.

[spring-projects-issues]

Suresh commented

Thank you for the response. I am going with id value in POJO and validating using hibernate validator.