Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HtmlUnitRequestBuilder should decode request parameter names [SPR-14177] #18748

Closed
spring-issuemaster opened this issue Apr 15, 2016 · 3 comments
Closed
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Apr 15, 2016

Martin Mahr opened SPR-14177 and commented

Request parameter name isn't decoded in method HtmlUnitRequestBuilder.params, but it should be.

Current implementation cannot handle URLs like:

http://server.cz/search?row[0]=foo&row[1]=bar

because it's encoded like:

http://server.cz/search?row%5B0%5D=foo&row%5B1%5D=bar

and HtmlUnitRequestBuilder leaves it as it is. The parameters then aren't mapped to @RequestParams or @ModelAttribute because of encoded special characters.


Affects: 4.2.5

Referenced from: commits 87ed8e9, 6500018

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Apr 15, 2016

Rob Winch commented

Thanks for the report! This is now fixed in 87ed8e9. This should be done building in the next hour or so and you can try the latest SNAPSHOT.

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Apr 18, 2016

Martin Mahr commented

Thank you for super quick response!

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Jul 2, 2016

Juergen Hoeller commented

Backported to 4.2.7 now along with another HtmlUnitRequestBuilder refinement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.