Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get/set-IfUnmodifiedSince, get/set-IfMatch methods on HttpHeaders [SPR-14228] #18802

Closed
spring-issuemaster opened this issue Apr 28, 2016 · 0 comments
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Apr 28, 2016

Sebastiaan van Erk opened SPR-14228 and commented

For a conditional PUT request I would like to use the If-Match header, however there is no corresponding get method on HttpHeaders. Similarly, there is no method for If-Unmodified-Since. The methods do exist for the If-None-Match and If-Modified since headers.

The methods are easy to add and quite useful for optimistic concurrency control on REST services.

For now there is a simple workaround for the missing If-Unmodified-Since method since the getFirstDate(String header) method is public, but it's a bit uglier for the If-Match header since the corresponding getFirstHeaderAsList(String header) method is protected.

Best regards,
Sebastiaan


Affects: 4.2.5

Issue Links:

  • INT-4017 Address the latest changes in the Spring Framework
  • #18797 Consistent handling of multi-valued headers in HttpHeaders
  • #18806 Add common non standard headers to HttpHeaders

Referenced from: commits 55dae61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.