Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactor2TcpClient does not remove TcpClient instances after connection closed [SPR-14231] #18805

Closed
spring-issuemaster opened this issue Apr 28, 2016 · 4 comments
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Apr 28, 2016

Rossen Stoyanchev opened SPR-14231 and commented

This was first reported in Boot 5810 where there is a detailed description.


Affects: 4.2.5

Issue Links:

  • #18803 Reactor2TcpClient leaks threads on shutdown

Referenced from: commits 220711d, d48eeb2

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Apr 28, 2016

Rossen Stoyanchev commented

Resolving for now since I verified the fix locally but I'm expecting a confirmation under the Boot ticket and will reopen if necessary.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented May 11, 2016

dave burns commented

Wasn't sure if I should comment on the original boot issue or open a new ticket but the issue (or similar issue) still occurs for a broker/server receiving simultaneous connections. I've modified the sample project and added a multi-threaded Junit method as a client. This launches 2000 concurrent threads, about 1100 successfully connect to the server (on my setup). I don't know if its the load or the failed connections (rather than clean disconnects) but the org.springframework.messaging.tcp.reactor.Reactor2TcpClient can be seen to be leaking following by the same instructions as in the original boot issue.

Weird thing is the original leak showed both the Reactor2TcpClient and StompBrokerRelayMessagHandler leaking, this just shows the reactor 2 client.

Noticed this in our production application, i.e. system accepting concurrent connections. The multi-threaded harness mimics this behavior.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented May 11, 2016

Rossen Stoyanchev commented

hi it's fine to open a ticket here but could you create a new one since this one is already closed and released.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented May 11, 2016

dave burns commented

Thanks, have created new ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.