Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactive HttpMessageReader/Writer for "x-www-form-url-encoded" data [SPR-14540] #19108

Closed
spring-projects-issues opened this issue Jul 29, 2016 · 4 comments

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Jul 29, 2016

Rossen Stoyanchev opened SPR-14540 and commented


Affects: 5.0 M1

Issue Links:

  • #19109 Reactive HTTP request data binding ("is depended on by")
  • #19710 Functional Web API support for HTML form processing ("is depended on by")

Referenced from: commits 46599e7

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Oct 19, 2016

Sébastien Deleuze commented

I think FormHttpMessageConverter reactive alternative will be composed of 3 distinct classes :

  • MultipartFormHttpMessageWriter
  • UrlEncodedFormHttpMessageReader
  • UrlEncodedFormHttpMessageWriter.
@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Oct 19, 2016

Rossen Stoyanchev commented

I think that makes sense and reader-writer split makes it easy to reflect such asymmetric cases. Perhaps we could shorten the names a bit, e.g. FormHttpMessageReader/Writer and MultipartHttpMessageWriter?

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Oct 20, 2016

Sébastien Deleuze commented

Yes, these shorter names are better indeed.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Oct 28, 2016

Rossen Stoyanchev commented

Resolving this since the form reader/writer are now in. The multipart writer is more related to the multipart request support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants