Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing MessageMethodArgumentResolver default constructor [SPR-14616] #19183

Closed
spring-projects-issues opened this issue Aug 23, 2016 · 2 comments
Closed
Assignees
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Aug 23, 2016

Juergen Hoeller opened SPR-14616 and commented

As raised in spring-projects/spring-kafka#172, MessageMethodArgumentResolver has a breaking change in 4.3 in that its default constructor got substituted with one accepting a MessageConverter. Let's reintroduce a default constructor side by side for backwards compatibility.


Affects: 4.3 GA

Issue Links:

  • #17878 @MessageMapping should support generically typed Message argument with converted payload

Referenced from: commits 7135bc2, c4fff6d

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Aug 23, 2016

Juergen Hoeller commented

MessageMethodArgumentResolver may work without a MessageConverter now in case of no payload conversion needed. The default constructor simply sets no such converter to begin with.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Aug 23, 2016

Artem Bilan commented

Juergen, thank you for fixing this!

Yes, I saw such a problem when we implemented null payload feature in Spring Kafka, but didn't pay attention that it really may be such a breaking change in SF.

Right now I would like to have an appropriate 4.3.3.BUILD-SNAPSHOT to test that issue and close as Works as Designed.

Thank you one more time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants