Fix assertions in StompHeaderAccessor [SPR-14625]

[spring-projects-issues]

Christoph Dreis opened SPR-14625 and commented

Hey,

while looking into #19191 I noticed another case of unnecessary and rather costly string concatenations. Not as severe as in #19191 but with a factor of 8 it still has an effect. Applications that send a lot of websocket messages could benefit from this as it eases the pressure on the heap.

Benchmark	Mode	Cnt	Score	Error	Units
MyBenchmark.testAssertNormal	thrpt	30	21121,046	225,696	ops/s
MyBenchmark.testAssertEnhanced	thrpt	30	173947,320	2253,248	ops/s

I used traditional if statements instead of the supplier functionality in Assert in order to be able to backport it to 4.3.x or even 4.2.x - much like the fixes for #19191.

Cheers

---

Affects: 4.2.7, 4.3.2

Reference URL: #1139

Issue Links:

• Improve performance of assertion in StompSubProtocolHandler [SPR-14624] #19191 Improve performance of assertion in StompSubProtocolHandler

Backported to: 4.2.8

[spring-projects-issues]

Sam Brannen commented

FYI: on Spring 5.0, the proposed changes can be rewritten as lambda expressions as follows.

Assert.state(SimpMessageType.MESSAGE.equals(getMessageType()), () -> "Unexpected message type " + getMessage());

Assert.state(SimpMessageType.MESSAGE.equals(getMessageType()), () -> "Unexpected message type " + getMessage());

[spring-projects-issues]

Christoph Dreis commented

I know - while working on #19191 I did it like this. But as it affects previous versions, I wanted to ease the backport process.

[spring-projects-issues]

Sam Brannen commented

Understood!

I hadn't seen #19191. So apologies for that.

[spring-projects-issues]

Juergen Hoeller commented

Good catch again... Those assertions in StompHeaderAccessor even included getMessage() instead of getMessageType(), and they unnecessarily use equals over an identity comparison for an enum value.

A further assertion in that class, in appendPayload, once again uses the wrong exception type and doesn't give any exception message at all. Fixed as well now.

[spring-projects-issues]

Juergen Hoeller commented

Last but not least, thanks for the detailed breakdown in the benchmark numbers! This is really useful insight.