Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResolvableType equals method should not consider TypeProvider source [SPR-14826] #19392

Closed
spring-projects-issues opened this issue Oct 19, 2016 · 0 comments

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Oct 19, 2016

Phil Webb opened SPR-14826 and commented

Originally discovered as part of spring-projects/spring-boot#7174

If two resolvable types are created from different fields, but would ultimately yield the same result they are currently not considered equal. This is because the method uses this.typeProvider.getSource(), I wonder if it should instead use this.typeProvider.getType()?


Affects: 4.3.3

Issue Links:

  • #20758 DispatcherHandler invoke wrong method when discriminating request with params

Referenced from: commits be187ba, adb9dc7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants