Type information not available on NoSuchBeanDefinitionException for collections [SPR-14831]

[spring-projects-issues]

Madhura Bhave opened SPR-14831 and commented

The original issue is in Spring Boot (spring-projects/spring-boot#6996). It would be helpful to get the type parameter for the NoSuchBeanDefinitionException for collections/maps to provide better failure analysis.

---

Affects: 4.3.3

[spring-projects-issues]

Stéphane Nicoll commented

I've a candidate fix in 522518f but I am not sure about the changes in DefaultListableBeanFactory. The logic of DepedencyDescriptor#getDependencyType() vs. DependencyDescriptor#getResolvableType().getRawClass() can lead to some sort of regressions.

Juergen Hoeller is that what you had in mind? I am feeling slightly nervous about that change now...

[spring-projects-issues]

Stéphane Nicoll commented

Juergen Hoeller I've polished my initial proposal and I think it's more in line with what we've discussed. I went ahead and merged that to master in b7d85f8. Can you please review and backport to 4.3?

[spring-projects-issues]

Phil Webb commented

Reopening for 4.3 backport

[spring-projects-issues]

Phil Webb commented

Also this line causes a NPE if the type is null.

[spring-projects-issues]

Stéphane Nicoll commented

Good catch, fixed the NPE.

[spring-projects-issues]

Juergen Hoeller commented

I've revised this a bit for 5.0 now (with streamlined constructors) and will backport a 4.3 variant tomorrow (keeping a deprecated constructor with a dependency String argument).