Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid use of double constructor of BigDecimal in tests [SPR-15077] #19643

Closed
spring-issuemaster opened this issue Dec 31, 2016 · 1 comment

Comments

@spring-issuemaster
Copy link
Collaborator

commented Dec 31, 2016

Philippe Marschall opened SPR-15077 and commented

Codacy warns about an Error Prone use of the double constructor of BigDecimal in tests. The reason given is that it is a source of precision loss if the number does not have an exact double representation. The recommendation is to use the String constructor of BigDecimal instead as it does not require using a lossy argument.


Issue Links:

  • #17928 Compatibility with merged JDK 9 mainline
  • #19642 Remove use of Boolean constructors in tests

Referenced from: pull request #1282

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 4, 2017

Stéphane Nicoll commented

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.