Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the logging documentation [SPR-15170] #19736

Closed
spring-projects-issues opened this issue Jan 20, 2017 · 4 comments
Closed

Improve the logging documentation [SPR-15170] #19736

spring-projects-issues opened this issue Jan 20, 2017 · 4 comments
Assignees
Labels
in: core type: documentation
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Jan 20, 2017

Matt Sicker opened SPR-15170 and commented

The current logging documentation references Log4j 1.x which is EOL. I'd like to add some updated docs for the logging section for Log4j 2.x and integration with SLF4J, a commonly used logging facade outside of this specific project.

I have a pull request here: #1279


Reference URL: #1279

Referenced from: commits f9a4856, 3e15573

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jan 20, 2017

Stéphane Nicoll commented

Thanks for the PR!

I polished it a bit to remove log4j 1.x altogether. There's no need to keep a section for if it's EOL anyway.

Juergen Hoeller I haven't backported this to 4.3.x yet. I guess we should probably keep the section on log4j 1.x there still? I can rework the pr for 4.3.x if you want. Let me know.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jan 20, 2017

Matt Sicker commented

As mentioned in the PR, make sure to include that Log4j 2.3 is the last supported release for Java 6. Thanks!

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jan 20, 2017

Juergen Hoeller commented

For 4.3.x, let's have a note on Log4j 1.x, mentioning its EOL. And indeed, let's also mention Log4j 2.3 as the last Java 6 compatible release there.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jan 20, 2017

Stéphane Nicoll commented

Alright, that's done in f9a4856

@spring-projects-issues spring-projects-issues added type: documentation in: core labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.3.6 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core type: documentation
Projects
None yet
Development

No branches or pull requests

2 participants