Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for single-pass matching in PathPattern [SPR-15419] #19980

Closed
spring-issuemaster opened this Issue Apr 7, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

spring-issuemaster commented Apr 7, 2017

Arjen Poutsma opened SPR-15419 and commented

Currently, both PathPattern.matches(String) and PathPattern.getPathRemaining(String) require an additional parsing pass to extract URI template variables (with matchAndExtract(String)). Moreover, dealing with a partial "prefix" match, like the ones matched by getPathRemaining, results in an IllegalStateException

This should be fixed by making these methods return an "info" object, containing a boolean flag indicating whether the given path matched, and the template variables, as well as the remaining path (in case of getPathRemaining


Issue Links:

  • #19873 Spring WebFlux using Kotlin with RouterDsl nested mappings not matching ("is depended on by")
  • #19899 Add PathPattern method that gives remaining path given a match
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.