Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ForwardedHeaderFilter.ForwardedHeaderRequestWrapper does not preserve encoding of requestURI [SPR-15422] #19983

Closed
spring-issuemaster opened this issue Apr 7, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Apr 7, 2017

Bryan Kelly opened SPR-15422 and commented

After adding the ForwardedHeaderFilter to our application we noticed that requests that are wrapped by the ForwardedHeaderRequestWrapper will no longer preserve encoding of the request.getRequestUri() and request.getRequestURL(). This is problematic when injecting a UriComponentsBuilder instance into a controller method because it will throw an Illegal character in path at index if the path contains characters that are expected to be encoded.


Affects: 4.3.7, 5.0 M5

Issue Links:

  • #19989 ForwardedHeaderFilter.ForwardedHeaderRequestWrapper does not preserve ;
@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 10, 2017

Rob Winch commented

Thanks for the report! This is now fixed in 4.3.x and master. I also fixed a related issue in which path variables were stripped out. See #19989

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 13, 2017

Bryan Kelly commented

I have been able to confirm that the changes fix the issue that was reported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.