Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ForwardedHeaderRequestWrapper should return a new StringBuffer instance on each invocation of the getRequestURL method [SPR-15423] #19984

Closed
spring-issuemaster opened this issue Apr 7, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

commented Apr 7, 2017

Bryan Kelly opened SPR-15423 and commented

ForwardedHeaderFilter returns the same StringBuffer for every invocation. This means that if the resulting StringBuffer is modified it changes the state of the HttpServletRequest.

Instead a new StringBuffer should be returned for every invocation.


Affects: 4.3.7, 5.0 M5

Referenced from: commits 9a91666, d0d7a88

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 10, 2017

Rob Winch commented

Thanks for the report and PR! This is now merged into 4.3.x and master

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 13, 2017

Bryan Kelly commented

I have been able to confirm that the changes fix the issue that was reported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.