ServerResponse.BodyBuilder.body(Object) shadows body(Publisher) in Kotlin ServerResponseExtensions [SPR-15467]

[spring-projects-issues]

Dariusz Bacinski opened SPR-15467 and commented

#20021

After linked change I am unable to pass Mono<List<String>> to body method.

The problem is that can't pass generic type of List<String>::class.java to body method.

Doesn't work:

val monoList: Mono<List<String>> = Mono.just(listOf("1", "2"))
ok().contentType(APPLICATION_JSON_UTF8).body(monoList, List<String>::class.java)

Works:

val flux: Flux<String> = Mono.just(listOf("1", "2")).flatMapIterable { it }
ok().contentType(APPLICATION_JSON_UTF8).body(flux,  String::class.java)

Code is written in Kotlin -, but I think it also applies to Java due to how generics works.-
It is very inconvenient that after linked change we have to provide exact type when we pass Publisher, before that it was not required.

---

Affects: 5.0 RC1

Issue Links:

• Add body(Object) method to ServerResponse.BodyBuilder [SPR-15461] #20021 Add body(Object) method to ServerResponse.BodyBuilder

Referenced from: commits b9dbac7

[spring-projects-issues]

Arjen Poutsma commented

This is specific to Kotlin, as the body(Object) method (unintentionally) overrides the body(Publisher) extension method in ServerResponseExtensions.kt, see here. It does not occur in Java, because there said method requires an extra Class parameter, see here.

[spring-projects-issues]

Arjen Poutsma commented

Fixed by renaming body(Object) to syncBody(Object), see b9dbac7