Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent and efficient access to BeanDefinition argument values [SPR-16192] #20740

Closed
spring-issuemaster opened this issue Nov 13, 2017 · 1 comment
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Nov 13, 2017

Juergen Hoeller opened SPR-16192 and commented

Starting with a nullability mismatch between AbstractBeanDefinition.getConstructorArgumentValues/getPropertyValues and its corresponding setters (which should get addressed for the Kotlin bean DSL), it turns out that all such access can be optimized through the introduction of hasConstructorArgumentValues/hasPropertyValues methods, never enforcing the creation of those holders objects unless actually necessary. The same applies to getMethodOverrides.


Issue Links:

  • #12149 Reduce footprint due to BeanDefinitions
  • #20347 Make getters and setters null-safety consistent

Referenced from: commits b5cedd4

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Nov 13, 2017

Sébastien Deleuze commented

Juergen Hoeller Very nice handling of the original issue, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.