Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket in WebFlux stack doesn't support Session Attributes [SPR-16212] #20760

Closed
spring-projects-issues opened this issue Nov 18, 2017 · 2 comments
Assignees
Labels
in: web type: enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Nov 18, 2017

Sola opened SPR-16212 and commented

Which has already supported in Servlet stack: https://docs.spring.io/spring/docs/current/javadoc-api/org/springframework/web/socket/WebSocketSession.html#getAttributes--


Affects: 5.0.1

Referenced from: commits 9074828, 192c7a5

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jan 9, 2018

Rossen Stoyanchev commented

Sorry for the slow response. I'm scheduling this for 5.1. Is there anything more you need aside from simply exposing a Map through WebSocketSession? For example are you looking to pass attributes from the handshake request WebSession to the WebSocketSession?

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented May 19, 2018

Rossen Stoyanchev commented

I've added attributes to WebSocketSession and also the ability to add attributes from the WebSession through a Predicate<String> for attribute names on HandshakeWebSocketService.

@spring-projects-issues spring-projects-issues added type: enhancement in: web labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.1 RC1 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants