Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RestOperations Kotlin extensions [SPR-16274] #20821

Closed
spring-issuemaster opened this issue Dec 6, 2017 · 0 comments
Closed

Improve RestOperations Kotlin extensions [SPR-16274] #20821

spring-issuemaster opened this issue Dec 6, 2017 · 0 comments

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Dec 6, 2017

Sébastien Deleuze opened SPR-16274 and commented

RestOperations Kotlin extensions should be improved on the following points.

1. Since type erasure can be fixed only when using ParameterizedTypeReference based Java methods, API documentation should be updated to avoid mentioning reified type parameters or getForObject() / getForEntity() should call internally exchange() with a ParameterizedTypeReference parameter.

Spring Boot TestRestTemplate extensions should be updated as well.

2. Nullability of parameters should be consistent with the Java API. It is currently not the case for requestEntity for example. Also potentially using null default parameters where that's possible could make sense.


Issue Links:

  • #20820 Clarify Kotlin reified type parameter extensions documentation about type erasure ("duplicates")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.