Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormTag renders empty <div> tag [SPR-16498] #21041

Closed
spring-issuemaster opened this issue Feb 14, 2018 · 1 comment
Closed

FormTag renders empty <div> tag [SPR-16498] #21041

spring-issuemaster opened this issue Feb 14, 2018 · 1 comment
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Feb 14, 2018

Delete this account opened SPR-16498 and commented

The doEndTag method in org/springframework/web/servlet/tags/form/FormTag.java uses writeHiddenFields to write the ExtraHiddenFields to a <div> tag. The if statement inside writeHiddenFields checks for hiddenFields being null, but in the case of it being an empty Map will write an empty <div></div> at the end of the <form>.

Possible solutions:

  • remove encapsulating <div>, possible hidden inputs would be direct children of the <form> tag
  • check hiddenFields not only for null but also for empty keyset in the if condition

Affects: 4.3.14

Referenced from: commits 350f318, 6d75732

Backported to: 4.3.15

@spring-issuemaster
Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Feb 14, 2018

Juergen Hoeller commented

Good point, we're simply checking CollectionUtils.isEmpty there now. To be backported to 4.3.15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.