WebClient retrieve() does not handle Void.class as recommended [SPR-16636]

[spring-projects-issues]

Mykola Varahash opened SPR-16636 and commented

Currently, when user tries to consume response body content in the following way:

WebClient client = ...;
Mono<Void> result = client.get().retrieve().bodyToMono(Void.class);
result.block();

and a response actually contains body content, then the underlying http connection will not be closed and returned to connections pool.

---

Affects: 5.0.4

Issue Links:

• Fix behavior of ClientResponse bodyToMono and bodyToFlux with Void.class [SPR-16018] #20567 Fix behavior of ClientResponse bodyToMono and bodyToFlux with Void.class

Referenced from: commits 729d0d2, e28a995

[spring-projects-issues]

Rossen Stoyanchev commented

What is this based on? Internally this calls consumeAndCancel which tries to consume, but raises and exception if any data comes in. The exception causes a cancellation signal upstream on the input Flux and that causes Reactor Netty to close the connection.

[spring-projects-issues]

Mykola Varahash commented

Please look at this DefaultWebClient.DefaultResponseSpec class
This code called when use "retrive()" function. The code which you pointer out called when use "exchange()" function.

[spring-projects-issues]

Rossen Stoyanchev commented

Ah, yes indeed, good catch!