New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Java Syntax in Spring Framework Documentation [SPR-16811] #21351

Closed
spring-issuemaster opened this Issue May 10, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

spring-issuemaster commented May 10, 2018

Sviatoslav Hryb opened SPR-16811 and commented

Section Data Access, paragraph 3.7.4. Handling complex types for stored procedure calls contains incorrect and not understandable fragments of Java code.

  1. One snippet of Java code doesn't contain a name of a variable of class TestItem (image1):
  2. Another snippet of code has several following problems: (image2).
  • doesn't contain a name of a variable of class TestItem
  • it is not perceivable why we need aforementioned variable
  • there is only an invocation of the method declareParameter without mentioned corresponding object of some class that invoke it.

Affects: 4.3.17, 5.0.6

Reference URL: https://docs.spring.io/spring/docs/5.0.6.RELEASE/spring-framework-reference/data-access.html#orm-general

Attachments:

Referenced from: commits 9d1789e, 2818051, 765d18e

Backported to: 4.3.18

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

spring-issuemaster commented May 15, 2018

Juergen Hoeller commented

Good catch! I've revised those examples accordingly. declareParameter was meant to be used from within the constructor of a StoredProcedure subclass, similar to earlier examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment